Just the ABI breaking parts of #1560 #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carroll <[email protected]>
chapulina
added
enhancement
chapulina
approved these changes
Jul 30, 2022
There was a problem hiding this comment.
Let's hope CI is happy. We should document the change in MinimumFeatureList on the migration guide.
It doesn't make a great migration experience for downstream developers to be changing these lists, but it looks to me that the new required features should be quick to implement.
Signed-off-by: Michael Carroll <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1624 +/- ##
==========================================
- Coverage 63.61% 63.58% -0.03%
==========================================
Files 330 330
Lines 25931 25950 +19
==========================================
+ Hits 16495 16500 +5
- Misses 9436 9450 +14
Continue to review full report at Codecov.
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's feature freeze, so getting the important stuff in.
#1560 is introducing may test failures, so this just lifts the minimal API breaking parts out.
Signed-off-by: Michael Carroll [email protected]