Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable building python bindings #1637

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

mjcarroll
Copy link
Contributor

🦟 Bug fix

Addresses gazebosim/gz-cmake#300

Summary

  • Adds SKIP_PYBIND11 to allow for Python binding generation to be skipped.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Aug 9, 2022
@mjcarroll mjcarroll self-assigned this Aug 9, 2022
@chapulina chapulina added the bug Something isn't working label Aug 9, 2022
@chapulina chapulina changed the base branch from main to gz-sim7 August 10, 2022 18:09
@ahcorde
Copy link
Contributor

ahcorde commented Aug 15, 2022

@osrf-jenkins run tests please!

@mjcarroll mjcarroll merged commit 9fc345c into gz-sim7 Aug 15, 2022
@mjcarroll mjcarroll deleted the mjcarroll/skip_generators branch August 15, 2022 16:57
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants