Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused function #1678

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Remove unused function #1678

merged 2 commits into from
Aug 30, 2022

Conversation

jennuine
Copy link
Contributor

@jennuine jennuine commented Aug 30, 2022 •
edited
Loading

🦟 Bug fix

Summary

c73c720 Removed GuiRunner::OnPluginAdded function that was left for abi compatibility in previous releases
68447cb Removed invalid TODO which was written before GuiRunner::UpdatePlugins was a Q_INVOKABLE function ( connect requires the receiver to be a QObject)

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@jennuine
remove unused function
c73c720 
Signed-off-by: Jenn Nguyen <[email protected]>
@jennuine
remove invalid TODO
68447cb 
Signed-off-by: Jenn Nguyen <[email protected]>
@jennuine jennuine added bug Something isn't working 🌱 garden Ignition Garden Breaking change Breaks API, ABI or behavior. Must target unstable version. labels Aug 30, 2022
@jennuine jennuine self-assigned this Aug 30, 2022
@jennuine jennuine mentioned this pull request Aug 30, 2022
Open
4 tasks
@jennuine
Copy link
Contributor Author

@osrf-jenkins run tests please

@jennuine jennuine merged commit 6184b54 into gz-sim7 Aug 30, 2022
@jennuine jennuine deleted the jennuine/minor_fixes branch August 30, 2022 17:51
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees

@jennuine jennuine

Labels
Breaking change Breaks API, ABI or behavior. Must target unstable version. bug Something isn't working 🌱 garden Ignition Garden
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennuine @chapulina