Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Trajectory loading seperated into external function #1744

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

onurtore
Copy link
Contributor

@onurtore onurtore commented Sep 29, 2022

🦟 Refactor

Summary

Refactors the trajectory loading code snippet into a separate function.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 29, 2022
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #1744 (9c37be8) into gz-sim7 (74854fd) will increase coverage by 0.00%.
The diff coverage is 68.75%.

@@           Coverage Diff            @@
##           gz-sim7    #1744   +/-   ##
========================================
  Coverage    63.90%   63.90%           
========================================
  Files          334      334           
  Lines        26338    26340    +2     
========================================
+ Hits         16830    16833    +3     
+ Misses        9508     9507    -1     
Impacted Files Coverage Δ
src/rendering/SceneManager.cc 28.54% <68.75%> (+0.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@onurtore
Copy link
Contributor Author

onurtore commented Oct 6, 2022

Ubuntu CI failed because it could not find the test file, however, this PR does not remove any test files, windows failed because it couldnt find some files which are not related to this PR.

@mjcarroll
Copy link
Contributor

@osrf-jenkins retest this please

@mjcarroll mjcarroll self-requested a review October 27, 2022 12:45
@mjcarroll
Copy link
Contributor

CI failures are unrelated to this PR.

@mjcarroll mjcarroll merged commit 6a326ac into gazebosim:gz-sim7 Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants