Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add namespace for GUI render event #1826

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Re-add namespace for GUI render event #1826

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/gui/plugins/scene3d/Scene3D.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,7 +778,7 @@ void IgnRenderer::Render()

if (ignition::gui::App())
{
gui::events::Render event;
ignition::gui::events::Render event;
Copy link
Contributor

@iche033 iche033 Dec 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are other places in ign-gazebo3 that uses gui::events::Render. Do they need to be updated as well? e.g. https:/gazebosim/gz-sim/blob/ign-gazebo3/src/gui/plugins/grid_config/GridConfig.cc#L90

Copy link
Contributor Author

@jennuine jennuine Dec 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, the bug lived in the sender. Anything listening to the render event doesn't need updated since both a ignition::gui::events::Render and ignition::gazebo::gui::events::Render are being sent: https:/gazebosim/gz-sim/blob/ign-gazebo3/include/ignition/gazebo/gui/GuiEvents.hh

Since both events are being broadcasted, plugins listening to either render event will be caught now (doesn't matter which one but preferably ignition::gui::events::Render since ignition::gazebo::gui::events::Render was removed in fortress)

ignition::gui::App()->sendEvent(
ignition::gui::App()->findChild<ignition::gui::MainWindow *>(),
&event);
Expand Down