Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading wold with record topic #1855

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Fix loading wold with record topic #1855

merged 1 commit into from
Jan 6, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jan 6, 2023

🦟 Bug fix

Summary

fix infinite loop when loading a world with LogRecord plugin and additional record_topic cmd line arg

Looks like this bug does not exist (or already fixed) in gz-sim7.

To test:

modify log_record_shapes.sdf and add an extra sdf plugin param <record_topic>/world/shapes/clock</record_topic> to the the LogRecord plugin, i.e.

    <plugin
      filename="ignition-gazebo-log-system"
      name="ignition::gazebo::systems::LogRecord">
      <record_topic>/world/shapes/clock</record_topic>
    </plugin>

launch gazebo with the following cmd line arg and verify that it does not go into infinite loop

ign gazebo -v 4 --record_topic /clock ./log_record_shapes.sdf

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <[email protected]>
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jan 6, 2023
@ahcorde ahcorde merged commit 48af3f6 into ign-gazebo3 Jan 6, 2023
@ahcorde ahcorde deleted the fix_record_topic branch January 6, 2023 09:33
@iche033 iche033 mentioned this pull request Jun 5, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants