Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Light class #1918

Merged
merged 5 commits into from
Mar 9, 2023
Merged

Add Light class #1918

merged 5 commits into from
Mar 9, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Mar 6, 2023

🎉 New feature

Part of #325

Summary

Add Light class to help ease migration from classic

Test it

Run the UNIT_Light_TEST and INTEGRATION_light tests

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested a review from mjcarroll as a code owner March 6, 2023 23:36
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 6, 2023
@iche033 iche033 changed the title Light api Add Light class Mar 6, 2023
Signed-off-by: Ian Chen <[email protected]>
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #1918 (a8f4bb1) into ign-gazebo6 (89df3b7) will increase coverage by 0.23%.
The diff coverage is 92.43%.

@@               Coverage Diff               @@
##           ign-gazebo6    #1918      +/-   ##
===============================================
+ Coverage        64.99%   65.22%   +0.23%     
===============================================
  Files              324      326       +2     
  Lines            26562    26813     +251     
===============================================
+ Hits             17264    17490     +226     
- Misses            9298     9323      +25     
Impacted Files Coverage Δ
src/Sensor.cc 85.71% <85.71%> (ø)
src/Light.cc 93.11% <93.11%> (ø)
src/Joint.cc 97.10% <100.00%> (+0.10%) ⬆️
src/SimulationRunner.cc 90.82% <0.00%> (-0.95%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@iche033 iche033 merged commit 55994da into ign-gazebo6 Mar 9, 2023
@iche033 iche033 deleted the light_api branch March 9, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants