Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorial on migrating the Actor class from gazebo classic #1929

Merged
merged 4 commits into from
Apr 27, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Mar 14, 2023

🎉 New feature

Part of #325

Summary

Add migration tutorial for Gazebo classic's Actor class.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested a review from mjcarroll as a code owner March 14, 2023 00:44
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 14, 2023
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #1929 (254f47a) into ign-gazebo6 (ef71b65) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 254f47a differs from pull request most recent head 16f468c. Consider uploading reports for the commit 16f468c to get more accurate results

@@               Coverage Diff               @@
##           ign-gazebo6    #1929      +/-   ##
===============================================
- Coverage        65.31%   65.29%   -0.02%     
===============================================
  Files              327      327              
  Lines            26893    26878      -15     
===============================================
- Hits             17566    17551      -15     
  Misses            9327     9327              

see 7 files with indirect coverage changes

Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 merged commit e11c2c2 into ign-gazebo6 Apr 27, 2023
@iche033 iche033 deleted the migration_actor branch April 27, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants