Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport sensors system threading optimization changes #2058

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Backport sensors system threading optimization changes #2058

merged 3 commits into from
Jul 31, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jul 27, 2023

🎉 New feature

Summary

Backport changes from #1938 and #2025

Test it

  • Run the INTEGRATION_sensors_system_update_rate test
  • Run the sensors_demo.sdf world to make sure sensors are working properly

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested a review from mjcarroll as a code owner July 27, 2023 21:57
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jul 27, 2023
@iche033
style
0dc3a9d 
Signed-off-by: Ian Chen <[email protected]>
ahcorde
ahcorde requested changes Jul 28, 2023
View reviewed changes
src/systems/sensors/Sensors.cc
@@ -17,7 +17,6 @@

#include "Sensors.hh"

#include <map>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

#include <atomic>
#include <chrono>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added. 1d762d9

test/integration/sensors_system_update_rate.cc Outdated
Comment on lines 79 to 80
const std::string sdfFile = std::string(PROJECT_SOURCE_PATH) +
"/test/worlds/sensor.sdf";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gz::common::joinPath

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated. 1d762d9

@iche033
style
1d762d9 
Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 requested a review from ahcorde July 28, 2023 19:55
@ahcorde ahcorde merged commit 8a4bc30 into ign-gazebo6 Jul 31, 2023
4 of 5 checks passed
@ahcorde ahcorde deleted the sensors_threading_6 branch July 31, 2023 06:57
@ahcorde ahcorde mentioned this pull request Aug 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
🏯 fortress Ignition Fortress
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iche033 @mjcarroll @ahcorde