Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent crash when viewing heightmap collision #2097

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Aug 25, 2023

🦟 Bug fix

Summary

If you try to view heightmap collisions (View > Collisions), the GUI crashes. This PR prints out a warning to say that it's not currently supported instead of just crashing.

The problem is that the heightmaps shaders currently expect texture maps exist (it does not work with just simple diffuse colors). If they are not available, the shaders fail to compile at runtime and cause the GUI to crash.

Note: I accidentally pushed to gz-sim7 and created a reverse commit (3f80b37) to undo the changes 🙇.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Aug 25, 2023
@azeey azeey added the beta Targeting beta release of upcoming collection label Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #2097 (5c0fd12) into gz-sim7 (3f80b37) will not change coverage.
Report is 1 commits behind head on gz-sim7.
The diff coverage is n/a.

❗ Current head 5c0fd12 differs from pull request most recent head da0e835. Consider uploading reports for the commit da0e835 to get more accurate results

@@           Coverage Diff            @@
##           gz-sim7    #2097   +/-   ##
========================================
  Coverage    64.96%   64.96%           
========================================
  Files          356      356           
  Lines        28791    28791           
========================================
  Hits         18704    18704           
  Misses       10087    10087           

@mjcarroll mjcarroll merged commit b46feef into gz-sim7 Aug 28, 2023
8 of 9 checks passed
@mjcarroll mjcarroll deleted the heightmap_view_collision branch August 28, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants