Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed python trace #2123

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 7, 2023

🦟 Bug fix

Fixes gazebosim/gazebo_test_cases#353

Summary

is there any reason to keep this trace here ? if this is required we can include a more verbose version

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@mjcarroll
Copy link
Contributor

is there any reason to keep this trace here ? if this is required we can include a more verbose version

Maybe just as a proof that something is happening in the example? I'm not sure what the original intent was here.

@azeey
Copy link
Contributor

azeey commented Sep 11, 2023

is there any reason to keep this trace here ? if this is required we can include a more verbose version

Maybe just as a proof that something is happening in the example? I'm not sure what the original intent was here.

Yes, that was the reason. It was there before I added the force application.

@mjcarroll mjcarroll merged commit 4135cd1 into gz-sim8 Sep 12, 2023
4 checks passed
@mjcarroll mjcarroll deleted the ahcorde/8/remove_python_system_trace branch September 12, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants