Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix light_control example and update tutorial #2149

Merged
merged 4 commits into from
Sep 15, 2023
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 14, 2023

🦟 Bug fix

gazebosim/gazebo_test_cases#285

Summary

Running the example had no effect because the light intensity defaults to 0 if not set. Updated the example to set the light intensity values and made some minor clarifications to the tutorial

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Sep 14, 2023
Signed-off-by: Ian Chen <[email protected]>
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #2149 (26a77db) into gz-sim8 (294fddc) will not change coverage.
Report is 1 commits behind head on gz-sim8.
The diff coverage is n/a.

❗ Current head 26a77db differs from pull request most recent head 93151c1. Consider uploading reports for the commit 93151c1 to get more accurate results

@@           Coverage Diff            @@
##           gz-sim8    #2149   +/-   ##
========================================
  Coverage    65.47%   65.47%           
========================================
  Files          323      323           
  Lines        30704    30704           
========================================
  Hits         20102    20102           
  Misses       10602    10602           

Signed-off-by: Ian Chen <[email protected]>
@ahcorde ahcorde merged commit b504e5c into gz-sim8 Sep 15, 2023
4 of 7 checks passed
@ahcorde ahcorde deleted the light_control_tutorial branch September 15, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants