Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GZ_PI instead of M_PI to fix windows builds #2230

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Nov 6, 2023

🦟 Bug fix

Fixes #2229

Summary

Some of the M_PI usage was introduced in #2185, but I also found another in the marker example.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey azeey requested a review from mjcarroll as a code owner November 6, 2023 20:58
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #2230 (b32b980) into gz-sim7 (45233fc) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head b32b980 differs from pull request most recent head 5e66988. Consider uploading reports for the commit 5e66988 to get more accurate results

@@             Coverage Diff             @@
##           gz-sim7    #2230      +/-   ##
===========================================
- Coverage    64.75%   64.75%   -0.01%     
===========================================
  Files          357      357              
  Lines        29145    29144       -1     
===========================================
- Hits         18874    18872       -2     
- Misses       10271    10272       +1     

see 2 files with indirect coverage changes

@azeey
Copy link
Contributor Author

azeey commented Nov 6, 2023

I think the windows failure is unrelated, so I'll go ahead and merge this.

@azeey azeey merged commit 82fbdba into gazebosim:gz-sim7 Nov 6, 2023
10 of 11 checks passed
@azeey azeey deleted the fix_m_pi branch November 6, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🧑‍🌾 Error C2065: 'M_PI': undeclared identifier in AdvancedLiftDrag.cc(618,64)
2 participants