Use sdf FindElement API to avoid const_cast #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several systems use const_cast in order to call sdf::Element::GetElement with const ElementPtrs, but the FindElement API can be used instead. Signed-off-by: Steve Peters <[email protected]>
mjcarroll
reviewed
Nov 7, 2023
src/systems/diff_drive/DiffDrive.cc
Outdated
| // Get params from SDF | ||
| sdf::ElementPtr sdfElem = ptr->GetElement("left_joint"); | ||
| sdf::ElementConstPtr sdfElem = _sdf->FindElement("left_joint"); |
There was a problem hiding this comment.
I think this is actually a good use case for auto. We shouldn't really care what the type is and the compiler should enforce the const correctness.
There was a problem hiding this comment.
ok, I'll update this and similar types to auto
There was a problem hiding this comment.
I had a fever, and the prescription was more auto
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2231 +/- ##
==========================================
- Coverage 65.90% 65.88% -0.03%
==========================================
Files 323 323
Lines 30719 30713 -6
==========================================
- Hits 20245 20234 -11
- Misses 10474 10479 +5
|
|
looks good to me. Windows CI needs gazebosim/gz-common#550 |
|
@osrf-jenkins retest this please |
mjcarroll
approved these changes
Nov 9, 2023
|
CI issues are unrelated, merging |
scpeters
added a commit
that referenced
this pull request
Nov 10, 2023
Several systems use const_cast in order to call sdf::Element::GetElement with const ElementPtrs, but the FindElement API can be used instead. Signed-off-by: Steve Peters <[email protected]>
8 tasks
mjcarroll
pushed a commit
that referenced
this pull request
Nov 13, 2023
Several systems use const_cast in order to call sdf::Element::GetElement with const ElementPtrs, but the FindElement API can be used instead. Signed-off-by: Steve Peters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes unneeded
const_castcalls.Summary
Several systems use
const_castin order to callsdf::Element::GetElementwith constElementPtrs, but theFindElementAPI can be used instead.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.