mecanum_drive: use mesh wheels in example world #2250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the Mecanum wheel meshes from the "Mecanum lift" model on Gazebo Fuel in the mecanum_drive example world. Signed-off-by: Steve Peters <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gz-sim7 #2250 +/- ##
===========================================
- Coverage 64.75% 64.72% -0.04%
===========================================
Files 357 357
Lines 29143 29142 -1
===========================================
- Hits 18873 18861 -12
- Misses 10270 10281 +11 ☔ View full report in Codecov by Sentry. |
ahcorde
approved these changes
Nov 20, 2023
examples/worlds/mecanum_drive.sdf
Outdated
| <geometry> | ||
| <sphere> | ||
| <!--sphere> |
There was a problem hiding this comment.
remove spheres and add a comment about the size of the wheels?
* Add comment about scale of mesh visual * Remove commented box, sphere geometries Signed-off-by: Steve Peters <[email protected]>
ahcorde
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Improves wheel visuals in the
mecanum_drive.sdfexample world.Summary
Use the Mecanum wheel meshes from the "Mecanum lift" model on Gazebo Fuel in the
mecanum_driveexample world.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.