Set max contacts for collision pairs #2270
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Depends on gazebosim/gz-physics#582
Summary
Set max_contacts physics parameter in physics engines that support this feature. See gazebosim/gz-physics#582 for support in dartsim's ode collision detector.
Test it
Here's an example test world: contacts.sdf.
The test world has a large box with an ellipsoid inside. The contact points are visualized in blue:
Before: No max contacts set. Many contacts detected. Low RTF (~30%)
After: Max contacts set based on SDF default value (20). Limited to 20 contacts. High RTF (~9X%)
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.