Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blast545/fix unused gcc warnings #2388

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

Blast545
Copy link
Contributor

@Blast545 Blast545 commented Apr 26, 2024

🦟 Bug fix

Fixes gcc warnings appearing in CI:
https://build.osrfoundation.org/job/gz_sim-ci-main-jammy-amd64/66/gcc/

Summary

Does not change at all the tests, just voids the variables so the compiler takes them as read and won't emit the warning

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Apr 26, 2024
@Blast545 Blast545 force-pushed the blast545/fix_unused_gcc_warnings branch from ae019b3 to e986c4b Compare April 26, 2024 21:21
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.91%. Comparing base (cffd297) to head (e986c4b).

Additional details and impacted files
@@           Coverage Diff            @@
##           gz-sim8    #2388   +/-   ##
========================================
  Coverage    65.91%   65.91%           
========================================
  Files          327      327           
  Lines        31314    31314           
========================================
  Hits         20641    20641           
  Misses       10673    10673           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Blast545
Copy link
Contributor Author

🧑‍🌾 Green CI, except on windows, INTEGRATION_mesh_inertia_calculation.test_ran seems to be flaky. FYI @Crola1702

Merging!

@Blast545 Blast545 merged commit 0b54328 into gz-sim8 Apr 29, 2024
10 of 11 checks passed
@Blast545 Blast545 deleted the blast545/fix_unused_gcc_warnings branch April 29, 2024 04:34
@Blast545 Blast545 mentioned this pull request May 2, 2024
Blast545 added a commit that referenced this pull request May 2, 2024
azeey pushed a commit that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants