Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding cone primitives. #2410

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Adding cone primitives. #2410

merged 3 commits into from
Jun 17, 2024

Conversation

bperseghetti
Copy link
Member

@bperseghetti bperseghetti commented May 15, 2024

🎉 New feature

Summary

This helps add the missing cone geometry for primitive/basic parametric shapes:

conetopple
cone

And is also valuable for visualizations of emitters/source that typically have conic-based spread as seen in this acoustic attack on an IMU by showing the affected area:

drone_attack

Associated PRs:

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Squashing commits to make requested target of main with backports to
harmonic.

Signed-off-by: Benjamin Perseghetti <[email protected]>
@scpeters
Copy link
Member

@osrf-jenkins run tests please

bperseghetti and others added 2 commits June 13, 2024 16:34
Co-authored-by: Steve Peters <[email protected]>
Signed-off-by: Benjamin Perseghetti <[email protected]>
Signed-off-by: Benjamin Perseghetti <[email protected]>
@ahcorde
Copy link
Contributor

ahcorde commented Jun 17, 2024

Thank you @bperseghetti , another great contribution!

@azeey or @scpeters do you mind to take a another look? CI is very green !

@ahcorde ahcorde merged commit 0d78194 into gazebosim:main Jun 17, 2024
8 checks passed
@scpeters
Copy link
Member

@azeey or @scpeters do you mind to take a another look? CI is very green !

I have suggested an update to our example worlds to include a cone in #2448

bperseghetti added a commit to rudislabs/gz-sim that referenced this pull request Jun 18, 2024
@bperseghetti bperseghetti deleted the pr-cone-main branch June 21, 2024 01:20
bperseghetti added a commit to rudislabs/gz-sim that referenced this pull request Jun 26, 2024
bperseghetti added a commit to rudislabs/gz-sim that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants