Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GravityEnabled boolean component #2451

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

scpeters
Copy link
Member

🎉 New feature

Follow-up to #2398, needed for #2447

Summary

This adds a boolean GravityEnabled component to the existing gz/sim/components/Gravity.hh header file, which should be used with Link entities instead of the Vector3 gravity component.

cc @AzulRadio

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jun 20, 2024
@scpeters scpeters mentioned this pull request Jun 20, 2024
9 tasks
@AzulRadio AzulRadio marked this pull request as ready for review June 23, 2024 17:12
@azeey azeey merged commit ca1b626 into ign-gazebo6 Jun 26, 2024
7 of 9 checks passed
@azeey azeey deleted the scpeters/gravity_enabled_component_6 branch June 26, 2024 02:35
@azeey azeey mentioned this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants