Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ignition related deprecations #2505

Merged
merged 4 commits into from
Aug 6, 2024
Merged

Remove ignition related deprecations #2505

merged 4 commits into from
Aug 6, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Aug 1, 2024

🦟 Bug fix

Summary

Drop support for ignition - gz sim will no longer check for ignition related env variables or systems.

This breaks backward compatibility. Gazebo will not be able to load old state log files , or world files with ignition::gazebo systems, including ones on Fuel.

Update: Restored code to load ignition gazebo systems. There are currently still many models on fuel (outside of openrobotics org) that use the deprecated ign prefix so we will keep supporting them.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 merged commit 811d4d0 into main Aug 6, 2024
9 checks passed
@iche033 iche033 deleted the deprecate_ign branch August 6, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants