Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

igniton gazebo fullscreen #254

Merged
merged 10 commits into from
Aug 14, 2020

Conversation

mohamedsayed18
Copy link
Contributor

Introduced a new parameter in the scene3D plugin to launch in fullscreen
fix #224

Signed-off-by: mohamedsayed18 <[email protected]>
@mohamedsayed18
Copy link
Contributor Author

<fullscreen>true</fullscreen>
The sdf for loading the plugin look like this

      <plugin filename="GzScene3D" name="3D View">
        <ignition-gui>
          <title>3D View</title>
          <property type="bool" key="showTitleBar">false</property>
          <property type="string" key="state">docked</property>
        </ignition-gui>

        <engine>ogre2</engine>
        <scene>scene</scene>
        <ambient_light>0.4 0.4 0.4</ambient_light>
        <background_color>0.8 0.8 0.8</background_color>
        <fullscreen>true</fullscreen>
      </plugin>

@chapulina chapulina added GUI Gazebo's graphical interface (not pure Ignition GUI) 🏰 citadel Ignition Citadel labels Jul 17, 2020
@chapulina chapulina self-requested a review July 17, 2020 15:00
@mohamedsayed18 mohamedsayed18 marked this pull request as ready for review July 20, 2020 15:54
@chapulina
Copy link
Contributor

@mohamedsayed18 is working on adding support for toggling fullscreen with the F11 key

@mohamedsayed18
Copy link
Contributor Author

the F11 now toggle between the fullscreen and normal window, I tried to make it maximized window but it didn't work I think maybe it is not supported for qwindow

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look too deeply, but when I started ign gazebo and pressed F11, nothing happened. I'm not sure why yet, would need to debug. Does that work for you?

src/gui/plugins/scene3d/Scene3D.cc Outdated Show resolved Hide resolved
@mohamedsayed18
Copy link
Contributor Author

It is working and compiling right now

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working for me! I just have one suggestion below, and also, mind documenting <fullscreen> on the header?

https:/ignitionrobotics/ign-gazebo/blob/8ec8d66cc8a6b661a2db6ccae153a785287fa315/src/gui/plugins/scene3d/Scene3D.hh#L60-L74

src/gui/plugins/scene3d/Scene3D.cc Outdated Show resolved Hide resolved
@mohamedsayed18
Copy link
Contributor Author

  • The world at the start
    fullscreen1

  • After pressing F11 (Fullscreen mode)
    Screenshot from 2020-08-14 18-11-06

  • After pressing F11 (Normal mode)
    full2

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chapulina chapulina merged commit ca72bee into gazebosim:ign-gazebo3 Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel GUI Gazebo's graphical interface (not pure Ignition GUI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants