Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore behavior change by reverting #2527 #2546

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Aug 26, 2024

🦟 Bug fix

Summary

#2527 reverted the changes introduced in #2452 because it's a behavior breaking change.

This PR restores the behavior change for main by undoing the changes in #2527.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <[email protected]>
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Aug 26, 2024
@azeey azeey added the beta Targeting beta release of upcoming collection label Aug 26, 2024
@iche033 iche033 merged commit 1184481 into main Aug 27, 2024
10 checks passed
@iche033 iche033 deleted the parent_entity_behavior_change branch August 27, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants