Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix particle emitter color range image path warning #2560

Merged
merged 6 commits into from
Sep 4, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Aug 30, 2024

🦟 Bug fix

Summary

Running the particle_emitter.sdf world prints the following warning:

[error] [GUI] SetColorRangeImage() error: Texture [materials/textures/fogcolors.png] not found. 

This PR makes sure that the full image path is constructed before gz-rendering creates the particle emitter. Note that this just fixes image path and gets rid of the warning but the gz::rendering::SetColorRangeImage function currently does not work (it has no effect) gazebosim/gz-rendering#902.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <[email protected]>
src/SdfEntityCreator.cc Outdated Show resolved Hide resolved
@ahcorde ahcorde enabled auto-merge (squash) September 4, 2024 14:44
@ahcorde ahcorde merged commit 8b74a43 into gz-sim9 Sep 4, 2024
10 checks passed
@ahcorde ahcorde deleted the particle_image_path branch September 4, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants