Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync components removal #272

Merged
merged 9 commits into from
Aug 28, 2020
Merged

Conversation

mcres
Copy link
Contributor

@mcres mcres commented Aug 5, 2020

It sets the SerializedStateMap and SerializedState messages when a component is removed after EntityComponentManager::RemoveComponent is called. This allows a more precise synchronization between the server and GUI EntityComponentManager.

This PR is made in order to solve an issue in #234 already described here (no. 3).

A couple of comments about the PR:

  • This TODO comment wasn't removed, given that the PR doesn't do any queuing.
  • I think the PR should have 2 tests: one that checks the SerializedStateMap message after calling RemoveComponent, and another one that checks that a component is actually removed when its remove flag in the message is set to true. I've implemented the first one and the second should be already done here.

@mcres mcres requested a review from chapulina as a code owner August 5, 2020 09:02
@mcres
Copy link
Contributor Author

mcres commented Aug 5, 2020

@azeey @mabelzhang

@mcres mcres mentioned this pull request Aug 5, 2020
@azeey azeey self-requested a review August 5, 2020 14:35
src/EntityComponentManager.cc Outdated Show resolved Hide resolved
src/EntityComponentManager.cc Outdated Show resolved Hide resolved
src/EntityComponentManager.cc Outdated Show resolved Hide resolved
src/EntityComponentManager.cc Outdated Show resolved Hide resolved
@chapulina chapulina added the 🔮 dome Ignition Dome label Aug 5, 2020
Signed-off-by: Martiño Crespo <[email protected]>
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! I left some comments mainly to improve test coverage. Let me know if you don't have enough time.

src/EntityComponentManager_TEST.cc Show resolved Hide resolved
src/EntityComponentManager.cc Outdated Show resolved Hide resolved
Signed-off-by: Martiño Crespo <[email protected]>
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! I have one last suggestion. Otherwise, this is good to go.

src/EntityComponentManager_TEST.cc Show resolved Hide resolved
src/EntityComponentManager_TEST.cc Show resolved Hide resolved
Signed-off-by: Martiño Crespo <[email protected]>
@azeey
Copy link
Contributor

azeey commented Aug 12, 2020

This looks ready to me. @chapulina, mind taking a quick look?

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for putting time into this. I just have a couple of minor comments for your consideration.

src/EntityComponentManager.cc Outdated Show resolved Hide resolved
src/SimulationRunner.cc Show resolved Hide resolved
Signed-off-by: Martiño Crespo <[email protected]>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, we should address the failing test on macOS.

src/EntityComponentManager_TEST.cc Outdated Show resolved Hide resolved
@mcres
Copy link
Contributor Author

mcres commented Aug 26, 2020

Is there anything that needs to be done yet?

@chapulina
Copy link
Contributor

@osrf-jenkins run tests please

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, this will be super helpful 👍

@chapulina chapulina merged commit 5b65ca6 into gazebosim:master Aug 28, 2020
mihirk284 pushed a commit to mihirk284/ign-gazebo that referenced this pull request Sep 1, 2020
Signed-off-by: Martiño Crespo <[email protected]>

Co-authored-by: Addisu Z. Taddese <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
ahcorde pushed a commit that referenced this pull request Sep 1, 2020
Signed-off-by: Martiño Crespo <[email protected]>

Co-authored-by: Addisu Z. Taddese <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants