Fix tests on Blueprint #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
chapulina
added
bug
Codecov Report
@@ Coverage Diff @@
## ign-gazebo2 #295 +/- ##
================================================
+ Coverage 53.78% 78.09% +24.30%
================================================
Files 121 183 +62
Lines 5838 9975 +4137
================================================
+ Hits 3140 7790 +4650
+ Misses 2698 2185 -513
Continue to review full report at Codecov.
|
JShep1
approved these changes
Aug 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We let some test failures slip in after #274. In particular, the support for finding worlds with the
IGN_GAZEBO_RESOURCE_PATHwas broken (ServerFixture.ResourcePath).So here I moved the logic that finds worlds all to the same place inside
Server. Having this search done as the server is instantiated also makes sure that all paths and callbacks needed have already been set. Searching for resources insideServerConfig.SetSdfPathoffers us less control about when that is checked, and kept it separate from the rest of the world finding logic.