Fix visibility macro names when used by a different component (Windows) #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chapulina
reviewed
Jan 15, 2021
There was a problem hiding this comment.
Wow I didn't know those macros even existed! I'm still not sure if the plugins need the visibility to be set though.
Codechecker is sad - otherwise the PR looks good to me.
/github/workspace/include/ignition/gazebo/gui/Gui.hh:63: Lines should be <= 80 characters long [whitespace/line_length] [2]
/github/workspace/src/systems/camera_video_recorder/CameraVideoRecorder.hh:44: Lines should be <= 80 characters long [whitespace/line_length] [2]
/github/workspace/src/systems/joint_position_controller/JointPositionController.hh:75: Lines should be <= 80 characters long [whitespace/line_length] [2]
/github/workspace/src/systems/logical_audio_sensor_plugin/LogicalAudioSensorPlugin.hh:132: Lines should be <= 80 characters long [whitespace/line_length] [2]
/github/workspace/src/systems/multicopter_control/MulticopterVelocityControl.hh:149: Lines should be <= 80 characters long [whitespace/line_length] [2]
/github/workspace/src/systems/multicopter_motor_model/MulticopterMotorModel.hh:37: Lines should be <= 80 characters long [whitespace/line_length] [2]
/github/workspace/src/systems/optical_tactile_plugin/OpticalTactilePlugin.hh:69: Lines should be <= 80 characters long [whitespace/line_length] [2]
/github/workspace/src/systems/triggered_publisher/TriggeredPublisher.hh:157: Lines should be <= 80 characters long [whitespace/line_length] [2]
Total errors found: 8
Yeah, I don't think we want them to be visible. I would in fact vote for making them |
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
…ivero/win/fix_visibility_names
j-rivero
force-pushed
the
jrivero/win/fix_visibility_names
branch
from
7d720f8
to
198d90a
Compare
Codecov Report
@@ Coverage Diff @@
## main #564 +/- ##
=======================================
Coverage 77.57% 77.57%
=======================================
Files 211 211
Lines 11582 11582
=======================================
Hits 8985 8985
Misses 2597 2597
Continue to review full report at Codecov.
|
I've removed visibility from all plugins.
I agree. I would leave the change of moving them to final classes in a different PR. |
chapulina
approved these changes
Jan 20, 2021
chapulina
pushed a commit
that referenced
this pull request
Jul 30, 2021
…s) (#564) Signed-off-by: Jose Luis Rivero <[email protected]>
chapulina
pushed a commit
that referenced
this pull request
Jul 30, 2021
…s) (#564) Signed-off-by: Jose Luis Rivero <[email protected]>
chapulina
pushed a commit
that referenced
this pull request
Jul 30, 2021
…s) (#564) Signed-off-by: Jose Luis Rivero <[email protected]>
chapulina
pushed a commit
that referenced
this pull request
Aug 4, 2021
…s) (#564) Signed-off-by: Jose Luis Rivero <[email protected]>
chapulina
pushed a commit
that referenced
this pull request
Aug 4, 2021
…s) (#564) Signed-off-by: Jose Luis Rivero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR solves a critical problem: when building a new component (new shared object) the visibility keyword can not be the same than a library it links to. This translated means: our systems and components can not use
IGNITION_GAZEBO_VISIBLEbut the custom name created by ign-cmake in the form ofIGNITION_GAZEBO_${COMPONENT_NAME}_VISIBLE. Otherwise there is a nice list of fanky linker errors all around.