Final Windows fixes to complete compilation #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <[email protected]>
…ivero/win/remove_visibility
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
…/ign-gazebo into jrivero/win/final_fixes Signed-off-by: Jose Luis Rivero <[email protected]>
…/ign-gazebo into jrivero/win/final_fixes Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
chapulina
reviewed
Jan 27, 2021
|
Nice! I see the build passing here: |
Signed-off-by: Jose Luis Rivero <[email protected]>
…nd lenght Signed-off-by: Jose Luis Rivero <[email protected]>
|
New test on Windows |
Codecov Report
@@ Coverage Diff @@
## main #585 +/- ##
=======================================
Coverage 77.38% 77.38%
=======================================
Files 213 213
Lines 11954 11954
=======================================
Hits 9251 9251
Misses 2703 2703
Continue to review full report at Codecov.
|
Signed-off-by: Jose Luis Rivero <[email protected]>
|
New test after fix visibility |
chapulina
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR include different fixes: