Depend on ignition-utils1 #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #591 +/- ##
==========================================
+ Coverage 77.33% 77.38% +0.05%
==========================================
Files 213 213
Lines 11952 11952
==========================================
+ Hits 9243 9249 +6
+ Misses 2709 2703 -6
Continue to review full report at Codecov.
|
ahcorde
approved these changes
Feb 2, 2021
|
The Windows failure isn't caused by this PR, I'll address that on a separate PR.
Thanks! I added you as a reviewer of #595 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #568
I didn't bother linking to the library in this PR, so this can focus on adding the dependency and getting CI turning.
I'll make a follow up PR that will actually use
ign-utils.