Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows build, again #616

Merged
merged 3 commits into from
Feb 8, 2021
Merged

Fix Windows build, again #616

merged 3 commits into from
Feb 8, 2021

Conversation

chapulina
Copy link
Contributor

Summary

Not sure why the Windows build was passing before without these fixes. In fact, I'm not sure why these aren't issues for other compilers 🤷‍♀️

In any case, this seems to fix it: Build Status

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See
    contributing)
  • All tests passed (See
    test coverage)
  • While waiting for a review on your PR, please help review
    another open pull request
    to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added bug Something isn't working Windows Windows support labels Feb 6, 2021
@chapulina chapulina requested a review from azeey as a code owner February 6, 2021 02:05
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Feb 6, 2021
@codecov
Copy link

codecov bot commented Feb 6, 2021

Codecov Report

Merging #616 (4a0457f) into main (6166234) will decrease coverage by 0.03%.
The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #616      +/-   ##
==========================================
- Coverage   77.38%   77.34%   -0.04%     
==========================================
  Files         213      213              
  Lines       11950    11967      +17     
==========================================
+ Hits         9247     9256       +9     
- Misses       2703     2711       +8     
Impacted Files Coverage Δ
include/ignition/gazebo/EntityComponentManager.hh 100.00% <ø> (ø)
include/ignition/gazebo/Server.hh 100.00% <ø> (ø)
include/ignition/gazebo/World.hh 100.00% <ø> (ø)
include/ignition/gazebo/components/Factory.hh 96.05% <ø> (ø)
...e/ignition/gazebo/detail/EntityComponentManager.hh 95.00% <ø> (ø)
include/ignition/gazebo/gui/GuiRunner.hh 100.00% <ø> (ø)
include/ignition/gazebo/gui/GuiSystem.hh 0.00% <ø> (ø)
include/ignition/gazebo/gui/TmpIface.hh 0.00% <ø> (ø)
src/Model.cc 95.58% <ø> (ø)
src/Server.cc 82.80% <ø> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ded6b92...4a0457f. Read the comment docs.

@chapulina chapulina merged commit 2f49e6f into main Feb 8, 2021
@chapulina chapulina deleted the chapulina/5/more_win branch February 8, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🏢 edifice Ignition Edifice Windows Windows support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants