Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add msg to show the computed temperature range computed from temperature gradient #643

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Feb 20, 2021

Signed-off-by: Ian Chen [email protected]

Summary

Currently users set the temperature gradient through sdf but there is no way to know what the actual temperature range that is computed from this gradient value. This PR adds a print statement to output the computed temperature range value

Test it

ign gazebo -v 4 src/ign-gazebo/examples/worlds/thermal_camera.sdf

and you should see the msg:

[Msg] Setting ambient temperature to 300 Kelvin and gradient to 0.1 K/m. The resulting temperature range is: 11.5444 Kelvin.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@github-actions github-actions bot added the 🔮 dome Ignition Dome label Feb 20, 2021
@iche033 iche033 closed this Feb 22, 2021
@iche033 iche033 reopened this Feb 22, 2021
@chapulina chapulina merged commit 20b6a9d into ign-gazebo4 Feb 23, 2021
@chapulina chapulina deleted the temp_range_msg branch February 23, 2021 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants