Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performer count #652

Merged
merged 12 commits into from
Mar 1, 2021
Merged

Performer count #652

merged 12 commits into from
Mar 1, 2021

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Feb 25, 2021

🎉 New feature

Summary

The performer detector will send information about when a performer enters or leaves a region, but does not include the number of entities in the region. The count is useful when, for example, a user wants to turn off a fog emitter only when the last robot leaves a region.

Test it

  1. ign gazebo -v 4 performer_detector.sdf
  2. ign topic -t "/model/vehicle_blue/cmd_vel" -m ignition.msgs.Twist -p "linear: {x: 0.5}"
  3. ign topic -et /performer_detector

You should see the following when the robot enters the region:

   data {
    key: "count"
    value: "1"
  }

and this when the robot leaves

   data {
    key: "count"
    value: "0"
  }

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Nate Koenig and others added 4 commits February 24, 2021 21:35
@nkoenig nkoenig requested a review from azeey February 25, 2021 17:42
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Feb 25, 2021
@nkoenig nkoenig changed the base branch from ign-gazebo4 to particle_modification February 25, 2021 17:43
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed a small typo. 7554335

Looks good to me.

Base automatically changed from particle_modification to ign-gazebo4 March 1, 2021 20:36
@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #652 (a38ff58) into ign-gazebo4 (1a16084) will decrease coverage by 0.03%.
The diff coverage is 73.94%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo4     #652      +/-   ##
===============================================
- Coverage        64.77%   64.74%   -0.04%     
===============================================
  Files              232      232              
  Lines            16590    16619      +29     
===============================================
+ Hits             10747    10760      +13     
- Misses            5843     5859      +16     
Impacted Files Coverage Δ
...rc/systems/performer_detector/PerformerDetector.hh 100.00% <ø> (ø)
src/systems/physics/Physics.cc 71.15% <73.27%> (-0.30%) ⬇️
...rc/systems/performer_detector/PerformerDetector.cc 88.07% <100.00%> (+0.33%) ⬆️
src/SimulationRunner.cc 92.88% <0.00%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a16084...a38ff58. Read the comment docs.

@nkoenig nkoenig merged commit 6b124f8 into ign-gazebo4 Mar 1, 2021
@nkoenig nkoenig deleted the performer_count branch March 1, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants