Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and alphabetize plugin headers #838

Merged
merged 1 commit into from
May 28, 2021
Merged

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented May 27, 2021

🦟 Bug fix

Summary

This is part of the effort to move some of the plugin living in ign-gazebo to ign-gui. Refer to this issue #835

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@ahcorde ahcorde added the enhancement New feature or request label May 27, 2021
@ahcorde ahcorde requested a review from mjcarroll May 27, 2021 19:11
@ahcorde ahcorde self-assigned this May 27, 2021
@ahcorde ahcorde requested a review from chapulina as a code owner May 27, 2021 19:11
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label May 27, 2021
@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #838 (235ff70) into ign-gazebo3 (65e8b04) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo3     #838      +/-   ##
===============================================
+ Coverage        77.93%   77.98%   +0.04%     
===============================================
  Files              216      216              
  Lines            12131    12131              
===============================================
+ Hits              9454     9460       +6     
+ Misses            2677     2671       -6     
Impacted Files Coverage Δ
src/gui/plugins/shapes/Shapes.cc 31.25% <ø> (ø)
.../gui/plugins/transform_control/TransformControl.cc 19.14% <ø> (ø)
src/SimulationRunner.cc 94.42% <0.00%> (+1.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65e8b04...235ff70. Read the comment docs.

Copy link
Contributor

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Assuming everything remaining are flaky tests?

@ahcorde ahcorde merged commit ee895b8 into ign-gazebo3 May 28, 2021
@ahcorde ahcorde deleted the ahcorde/cleanup/headers branch May 28, 2021 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants