Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed and moved tape measure and grid config to ign-gui #870

Merged
merged 2 commits into from
Jun 22, 2021
Merged

Removed and moved tape measure and grid config to ign-gui #870

merged 2 commits into from
Jun 22, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jun 21, 2021

Signed-off-by: ahcorde [email protected]

🎉 Enhancement

Summary

There are some plugins which are ign-gui specific. This PR moves tape_measure and grid_config to ign-gui.

Related with this issue #835

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@ahcorde ahcorde added the 🏯 fortress Ignition Fortress label Jun 21, 2021
@ahcorde ahcorde requested a review from chapulina as a code owner June 21, 2021 09:28
@ahcorde ahcorde self-assigned this Jun 21, 2021
@ahcorde ahcorde mentioned this pull request Jun 21, 2021
Closed
@mjcarroll
Copy link
Contributor

Bionic CI is failing on a performance test, unrelated to this PR

@chapulina
Update migration guide
f9b1674 
Signed-off-by: Louise Poubel <[email protected]>
chapulina
chapulina approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smooth. I believe Gazebo users won't even notice what happened 😄 And Ignition GUI users just received some new goodies 🍬

gazebosim/gz-gui#236 has been merged, so this is good to go.

@chapulina chapulina merged commit 8498dc1 into main Jun 22, 2021
@chapulina chapulina deleted the ahcorde/move_plugin_to_gui branch June 22, 2021 23:52
@ahcorde ahcorde mentioned this pull request Jul 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees

@ahcorde ahcorde

Labels
🏯 fortress Ignition Fortress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahcorde @mjcarroll @chapulina