Fix codecheck #887
Merged
Fix codecheck #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nate Koenig <[email protected]>
mjcarroll
approved these changes
Jun 25, 2021
Codecov Report
@@ Coverage Diff @@
## ign-gazebo4 #887 +/- ##
===============================================
- Coverage 65.98% 65.97% -0.01%
===============================================
Files 239 239
Lines 17657 17657
===============================================
- Hits 11651 11650 -1
- Misses 6006 6007 +1
Continue to review full report at Codecov.
|
chapulina
pushed a commit
that referenced
this pull request
Jul 23, 2021
Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
chapulina
pushed a commit
that referenced
this pull request
Jul 23, 2021
Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nate Koenig [email protected]
🦟 Bug fix
Summary
I had a custom sensor plugin that did not register a remove sensor callback, which ended up causing a segfault in RenderUtils.cc. Problem is solved by checking the callback function before calling it.
I fixed codecheck warnings for good measure.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge