Make breadcrumb static after specified time #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: iche033 <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
azeey
reviewed
Apr 27, 2020
azeey
approved these changes
Apr 28, 2020
| #include "ignition/gazebo/components/Geometry.hh" | ||
| #include "ignition/gazebo/components/Link.hh" | ||
| #include "ignition/gazebo/components/DetachableJoint.hh" |
There was a problem hiding this comment.
Duplicate
Suggested change
| #include "ignition/gazebo/components/DetachableJoint.hh" |
Signed-off-by: Ian Chen <[email protected]>
nkoenig
force-pushed
the
breadcrumbs_exit_early
branch
2 times, most recently
from
ded47ae
to
b8ac88b
Compare
Signed-off-by: Ian Chen <[email protected]>
nkoenig
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
<disable_physics_time>param to the breadcrumbs plugin, which allows users to make the breadcrumb model static after the specified time. The timer starts when the model is spawned into the world.Note that the model is currently made static by attaching it to a static entity. We can switch to using an ignition-physics API for doing this when that feature is available.
Signed-off-by: Ian Chen [email protected]