Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity tree: prevent creation of repeated entity items #974

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

chapulina
Copy link
Contributor

Signed-off-by: Louise Poubel [email protected]

🦟 Bug fix

Summary

Broken off #793.

We should never get into this situation, and if we do, it means there's some internal problem. I'm not sure how to reproduce it, but it's a good idea to guard against it anyway.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina requested a review from ahcorde August 14, 2021 01:27
@chapulina chapulina added the GUI Gazebo's graphical interface (not pure Ignition GUI) label Aug 14, 2021
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Aug 14, 2021
@codecov
Copy link

codecov bot commented Aug 14, 2021

Codecov Report

Merging #974 (7fb309a) into ign-gazebo3 (4a5a33d) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 7fb309a differs from pull request most recent head 1abfd20. Consider uploading reports for the commit 1abfd20 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo3     #974      +/-   ##
===============================================
- Coverage        77.86%   77.84%   -0.03%     
===============================================
  Files              221      221              
  Lines            12683    12687       +4     
===============================================
  Hits              9876     9876              
- Misses            2807     2811       +4     
Impacted Files Coverage Δ
src/gui/plugins/entity_tree/EntityTree.cc 12.83% <0.00%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a5a33d...1abfd20. Read the comment docs.

@ahcorde ahcorde merged commit 7d1a3e0 into ign-gazebo3 Aug 16, 2021
@ahcorde ahcorde deleted the chapulina/3/tree_warn branch August 16, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel GUI Gazebo's graphical interface (not pure Ignition GUI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants