Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing parameters PR (#305) with prerelease repos #349

Closed

Conversation

scpeters
Copy link
Member

This is a test branch level with #305 that is using the ci_matching_branch/* branch name with matching branches in gzdev and homebrew-simulation to test with prerelease packages.

ivanpauno and others added 29 commits May 24, 2022 15:58
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
* Document ParametersClient.

Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
… server and client

Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Aug 18, 2022
@scpeters scpeters mentioned this pull request Aug 18, 2022
10 tasks
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #349 (1bcb2e4) into ign-transport11 (991dfe7) will decrease coverage by 0.28%.
The diff coverage is 83.97%.

@@                 Coverage Diff                 @@
##           ign-transport11     #349      +/-   ##
===================================================
- Coverage            88.86%   88.58%   -0.29%     
===================================================
  Files                   51       59       +8     
  Lines                 4777     5089     +312     
===================================================
+ Hits                  4245     4508     +263     
- Misses                 532      581      +49     
Impacted Files Coverage Δ
parameters/src/Client.cc 78.88% <78.88%> (ø)
parameters/src/Registry.cc 83.46% <83.46%> (ø)
parameters/src/cmd/ParamCommandAPI.cc 84.61% <84.61%> (ø)
parameters/src/Utils.cc 85.71% <85.71%> (ø)
...rs/include/ignition/transport/parameters/Client.hh 100.00% <100.00%> (ø)
...include/ignition/transport/parameters/Interface.hh 100.00% <100.00%> (ø)
.../include/ignition/transport/parameters/Registry.hh 100.00% <100.00%> (ø)
...nclude/ignition/transport/parameters/exceptions.hh 100.00% <100.00%> (ø)
include/ignition/transport/Discovery.hh 85.42% <0.00%> (+0.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@scpeters
Copy link
Member Author

@ivanpauno it looks like the change in gazebosim/gz-msgs#298 fixes compilation, but now the windows tests are failing to link

LINK : fatal error LNK1181: cannot open input file '..\..\lib\Release\ignition-transport11-parameters.lib' [C:\Jenkins\workspace\ign_transport-pr-win\ws\build\ignition-transport11\parameters\src\UNIT_Client_TEST.vcxproj]
...
LINK : fatal error LNK1181: cannot open input file '..\..\lib\Release\ignition-transport11-parameters.lib' [C:\Jenkins\workspace\ign_transport-pr-win\ws\build\ignition-transport11\parameters\src\UNIT_Registry_TEST.vcxproj]

perhaps we need to add a dependency on the parameters component to the tests?

@ivanpauno
Copy link
Contributor

perhaps we need to add a dependency on the parameters component to the tests?

I'm trying to figure it out, it seems that tests are failing to link to the new parameters component libary.
I'm comparing with the CMakeLists.txt of the log component and IDK what can be causing the issue

@scpeters
Copy link
Member Author

perhaps we need to add a dependency on the parameters component to the tests?

I'm trying to figure it out, it seems that tests are failing to link to the new parameters component libary. I'm comparing with the CMakeLists.txt of the log component and IDK what can be causing the issue

yeah I've looked to and can't figure out what is going on

ivanpauno and others added 5 commits August 25, 2022 14:17
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters force-pushed the ci_matching_branch/parameters-component11 branch from 24610a9 to 1688b63 Compare August 26, 2022 00:11
ivanpauno and others added 10 commits August 31, 2022 10:53
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@scpeters scpeters closed this Sep 29, 2022
@scpeters scpeters deleted the ci_matching_branch/parameters-component11 branch September 29, 2022 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants