Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support clang and std::filesystem #390

Merged
merged 2 commits into from
Mar 16, 2023
Merged

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Mar 14, 2023

🎉 New feature

Summary

Support clang when checking for filesystem support.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig requested a review from caguero as a code owner March 14, 2023 05:06
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Mar 14, 2023
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #390 (3d5471a) into ign-transport8 (cb1c95b) will increase coverage by 0.00%.
The diff coverage is 88.37%.

❗ Current head 3d5471a differs from pull request most recent head ce80df6. Consider uploading reports for the commit ce80df6 to get more accurate results

@@               Coverage Diff               @@
##           ign-transport8     #390   +/-   ##
===============================================
  Coverage           83.61%   83.61%           
===============================================
  Files                  51       51           
  Lines                5035     5036    +1     
===============================================
+ Hits                 4210     4211    +1     
  Misses                825      825           
Impacted Files Coverage Δ
include/gz/transport/Packet.hh 0.00% <0.00%> (ø)
...og/include/gz/transport/log/detail/QueryOptions.hh 100.00% <ø> (ø)
log/src/Batch.cc 89.28% <ø> (ø)
log/src/Descriptor.cc 89.65% <ø> (ø)
log/src/Descriptor.hh 100.00% <ø> (ø)
log/src/Log.cc 78.72% <ø> (ø)
log/src/Message.cc 100.00% <ø> (ø)
log/src/MsgIter.cc 80.43% <ø> (ø)
log/src/QualifiedTime.cc 97.81% <ø> (ø)
log/src/QueryOptions.cc 100.00% <ø> (ø)
... and 40 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nkoenig nkoenig merged commit 559ba5a into ign-transport8 Mar 16, 2023
@nkoenig nkoenig deleted the nkoenig/clang_filesystem branch March 16, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants