Merge gz-transport12 ➡️ main #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
mjcarroll
approved these changes
Aug 29, 2023
|
The I'll try changing to |
Signed-off-by: Addisu Z. Taddese <[email protected]>
azeey
commented
Aug 29, 2023
| @@ -101,15 +101,19 @@ TEST_F(ParametersClientTest, cmdParameterGet) | |||
| cmdParameterGet("", "parameter1"); | |||
| auto output = coutCapture.str(); | |||
| EXPECT_NE(std::string::npos, output.find("gz_msgs.Boolean")); | |||
| EXPECT_EQ(cerrCapture.str(), ""); | |||
| // TODO(azeey) Uncomment after | |||
There was a problem hiding this comment.
These changes are not part of the merge forward. They were needed to make tests pass. See #435
|
For some reason the Jammy Jenkins job wasn't started automatically. |
Codecov Report
@@ Coverage Diff @@
## main #434 +/- ##
==========================================
+ Coverage 87.75% 87.79% +0.04%
==========================================
Files 59 59
Lines 5693 5696 +3
==========================================
+ Hits 4996 5001 +5
+ Misses 697 695 -2
|
iche033
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
gz-transport12➡️mainBranch comparison: main...gz-transport12
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)