Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tutorials/05_services: Windows improvements #536

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

peci1
Copy link
Contributor

@peci1 peci1 commented Sep 15, 2024

🦟 Bug fix

Fixes gazebosim/gazebo_test_cases#1542

Summary

Improved a few commandlines to include Windows instructions.

Added a notice about GZ_PARTITION, which is often problematic on Windows.

Added a notice about firewall prompts.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033
Copy link
Contributor

iche033 commented Sep 16, 2024

homebrew is failing because of osrf/homebrew-simulation#2791. This PR touches only the tutorial file so should be safe to merge.

@iche033 iche033 merged commit 8e27a44 into gazebosim:gz-transport14 Sep 16, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

gz-transport: Services
3 participants