Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 24.04 CI #129

Merged
merged 1 commit into from
May 1, 2024
Merged

Enable 24.04 CI #129

merged 1 commit into from
May 1, 2024

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented May 1, 2024

🎉 New feature

Attempting to enable CI on 24.04, similar to gazebosim/gz-math#587

Summary

Adds a workflow using the noble branch of gazebo-tooling/action-gz-ci. Also switches to actions/checkout@v4.

Test it

Observe the CI results.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Also switch to `actions/checkout@v4`.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from azeey as a code owner May 1, 2024 17:28
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.79%. Comparing base (3838ce6) to head (6fbedb6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #129   +/-   ##
=======================================
  Coverage   81.79%   81.79%           
=======================================
  Files           8        8           
  Lines         401      401           
=======================================
  Hits          328      328           
  Misses         73       73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scpeters scpeters merged commit d9456d6 into main May 1, 2024
12 checks passed
@scpeters scpeters deleted the scpeters/noble branch May 1, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants