Fix two tests on Windows #1779
Merged
Fix two tests on Windows #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use NormalizeDirectoryPath to fix path comparisons. Signed-off-by: Steve Peters <[email protected]>
mjcarroll
approved these changes
Nov 3, 2022
|
|
|
oops, I just pushed another test fix |
Signed-off-by: Steve Peters <[email protected]>
scpeters
force-pushed
the
scpeters/debug_system_loader_test
branch
from
20c226b
to
5a1193e
Compare
I guess it's only on garden |
no it's in SystemPaths |
Signed-off-by: Steve Peters <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1779 +/- ##
============================================
Coverage 64.61% 64.61%
============================================
Files 321 321
Lines 26290 26290
============================================
Hits 16988 16988
Misses 9302 9302 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes failing test on windows.
Summary
The UNIT_SystemLoader_TEST has been failing on ign-gazebo6 since build 138 when #1685 was merged.
From debugging, I noticed that the problem was a trailing
\in one set of paths but not the other. I've usedNormalizeDirectoryPathto fix the path comparisons.Also fixes
UNIT_Server_TESTChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.