Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for bazel in garden #325

Merged
merged 6 commits into from
Mar 6, 2023
Merged

Support for bazel in garden #325

merged 6 commits into from
Mar 6, 2023

Conversation

mjcarroll
Copy link
Contributor

No description provided.

@mjcarroll
Support for bazel in Garden
f2d8768 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Update location
7085b73 
Signed-off-by: Michael Carroll <[email protected]>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Feb 10, 2023
@mjcarroll mjcarroll mentioned this pull request Feb 10, 2023
Open
33 tasks
caguero
caguero reviewed Feb 14, 2023
View reviewed changes
Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any recommendation or tutorial for checking this PR?

@mjcarroll
Copy link
Contributor Author

Do you have any recommendation or tutorial for checking this PR?

This is the CI for it: gazebosim/gz-bazel#51

Instructions are here, but are incomplete as we are working up the stack: https:/gazebosim/gz-bazel

@codecov
Copy link

codecov bot commented Feb 14, 2023 •
edited
Loading

Codecov Report

Merging #325 (1ca8f40) into gz-msgs9 (5a6edd1) will not change coverage.
The diff coverage is n/a.

❗ Current head 1ca8f40 differs from pull request most recent head 9115eb6. Consider uploading reports for the commit 9115eb6 to get more accurate results

@@            Coverage Diff            @@
##           gz-msgs9     #325   +/-   ##
=========================================
  Coverage     95.41%   95.41%           
=========================================
  Files            10       10           
  Lines          1026     1026           
=========================================
  Hits            979      979           
  Misses           47       47

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

caguero
caguero approved these changes Feb 17, 2023
View reviewed changes
Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me following https:/gazebosim/gz-bazel

@mjcarroll mjcarroll merged commit 2aaece3 into gz-msgs9 Mar 6, 2023
@mjcarroll mjcarroll deleted the mjcarroll/garden_bazel branch March 6, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caguero caguero caguero approved these changes

Assignees
No one assigned
Labels
🌱 garden Ignition Garden
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjcarroll @caguero