Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should permit nesting models without links (e.g. defining frames / visuals / collision only)? #336

Closed
EricCousineau-TRI opened this issue Aug 13, 2020 · 3 comments
Assignees

Comments

@EricCousineau-TRI
Copy link
Collaborator

In SDFormat 1.7, we admit models with no links iff they are //static=true, and the canonical link for those models are attached to the world:
http://sdformat.org/tutorials?tut=pose_frame_semantics_proposal&cat=pose_semantics_docs&#2-1-implicit-frame-defined-by-model-pose-attached-to-canonical-link

However, @azeey pointed out that we may want similar behavior for nested models:
gazebosim/sdf_tutorials#34 (review)

@EricCousineau-TRI
Copy link
Collaborator Author

Thoughts:

  • Not sure how I personally feel about just adding frames / visuals / collision without inertias. (if you're adding new collisions via SDFormat, they should be real and physical?)
  • Not sure how I feel about this when the adding element will have scoped names.

So thinking about this, my gut says we punt for now on SDFormat 1.8.

@EricCousineau-TRI EricCousineau-TRI changed the title SDFormat 1.8: Should permit nesting models without links (e.g. defining frames / visuals / collision only)? Should permit nesting models without links (e.g. defining frames / visuals / collision only)? Aug 13, 2020
@EricCousineau-TRI
Copy link
Collaborator Author

This should've been accomplished for static models per latest PRs from @azeey

@brawner to confirm that this is already covered in a unittest.

@brawner
Copy link
Collaborator

brawner commented Dec 17, 2020

Resolved via #341 and is tested in the model_dom.cc integration test DOMRoot.LoadNestedCanonicalLink and DOMRoot.LoadNestedExplicitCanonicalLink (https:/osrf/sdformat/blob/5a910816ef57ebd34aa4cf0c0a233750d8af88b3/test/integration/model_dom.cc#L433-L531)

@brawner brawner closed this as completed Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants