Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test using __model__, world in @attached_to, @relative_to #1066

Merged
merged 5 commits into from
Jul 22, 2022

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Jul 6, 2022

🦟 Bug fix

Counterpart to gazebosim/sdf_tutorials#77

Summary

As noted in gazebosim/sdf_tutorials#77, it was unclear in our documentation that __model__ and world can be used explicitly in the //frame/@attached_to and //pose/@relative_to attributes in the proper context. As that pull request updates the documentation, this pull request uses these values explicitly in test/sdf files and in corresponding integration tests.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters scpeters requested a review from azeey as a code owner July 6, 2022 22:52
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Jul 6, 2022
Signed-off-by: Steve Peters <[email protected]>
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #1066 (1f336f6) into sdf9 (e9e9546) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 1f336f6 differs from pull request most recent head 96aec38. Consider uploading reports for the commit 96aec38 to get more accurate results

@@           Coverage Diff           @@
##             sdf9    #1066   +/-   ##
=======================================
  Coverage   87.59%   87.59%           
=======================================
  Files          64       64           
  Lines       10061    10061           
=======================================
  Hits         8813     8813           
  Misses       1248     1248           
Impacted Files Coverage Δ
src/Model.cc 83.70% <ø> (ø)
src/parser.cc 79.05% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9e9546...96aec38. Read the comment docs.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from marcoag July 19, 2022 20:08
@scpeters scpeters merged commit 09f44c1 into sdf9 Jul 22, 2022
@scpeters scpeters deleted the scpeters/explicit_model_world_references branch July 22, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants