Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to skip python bindings #1106

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Conversation

mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented Aug 9, 2022

🦟 Bug fix

Addresses gazebosim/gz-cmake#300

Summary

Adds SKIP_PYBIND11 to allow for Python binding generation to be skipped.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Michael Carroll <[email protected]>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Aug 9, 2022
@mjcarroll mjcarroll self-assigned this Aug 9, 2022
@chapulina chapulina added the bug Something isn't working label Aug 9, 2022
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #1106 (09eb94d) into sdf13 (78adf4c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            sdf13    #1106   +/-   ##
=======================================
  Coverage   86.70%   86.70%           
=======================================
  Files         125      125           
  Lines       15890    15890           
=======================================
  Hits        13778    13778           
  Misses       2112     2112           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scpeters
Copy link
Member

@osrf-jenkins run tests please

@scpeters scpeters merged commit fb48f02 into sdf13 Aug 11, 2022
@scpeters scpeters deleted the mjcarroll/skip_generators branch August 11, 2022 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants