Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <double_sided> to material spec #410

Merged
merged 4 commits into from
Nov 17, 2020
Merged

Add <double_sided> to material spec #410

merged 4 commits into from
Nov 17, 2020

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Nov 4, 2020

Add new SDF parameter for configuring a material's double sided property. If set to true, the mesh will be rendered as double sided, i.e. every polygon of a mesh will be visible from both the front and back sides. The default value is false.

@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🔮 dome Ignition Dome labels Nov 4, 2020
@codecov-io
Copy link

codecov-io commented Nov 4, 2020

Codecov Report

Merging #410 (d9bf24e) into sdf10 (d0014d2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            sdf10     #410      +/-   ##
==========================================
+ Coverage   87.50%   87.52%   +0.01%     
==========================================
  Files          61       61              
  Lines        9327     9337      +10     
==========================================
+ Hits         8162     8172      +10     
  Misses       1165     1165              
Impacted Files Coverage Δ
src/Material.cc 98.07% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0014d2...d9bf24e. Read the comment docs.

Copy link
Member

@luca-della-vedova luca-della-vedova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@iche033 iche033 merged commit c1e703d into sdf10 Nov 17, 2020
@iche033 iche033 deleted the double_sided_material branch November 17, 2020 00:17
iche033 added a commit that referenced this pull request Nov 17, 2020
* add double sided materail param

Signed-off-by: Ian Chen <[email protected]>

* fix loading param

Signed-off-by: Ian Chen <[email protected]>
azeey pushed a commit to azeey/sdformat that referenced this pull request Dec 9, 2020
* add double sided materail param

Signed-off-by: Ian Chen <[email protected]>

* fix loading param

Signed-off-by: Ian Chen <[email protected]>
brawner pushed a commit that referenced this pull request Dec 11, 2020
* add double sided materail param

Signed-off-by: Ian Chen <[email protected]>

* fix loading param

Signed-off-by: Ian Chen <[email protected]>
scpeters pushed a commit that referenced this pull request Dec 15, 2020
* add double sided materail param

Signed-off-by: Ian Chen <[email protected]>

* fix loading param

Signed-off-by: Ian Chen <[email protected]>
@azeey azeey mentioned this pull request Dec 15, 2020
brawner pushed a commit that referenced this pull request Jan 9, 2021
* add double sided materail param

Signed-off-by: Ian Chen <[email protected]>

* fix loading param

Signed-off-by: Ian Chen <[email protected]>
scpeters pushed a commit to scpeters/sdformat that referenced this pull request May 17, 2021
* add double sided material param
* added to sdf 1.7 in gazebosim#410

Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
scpeters added a commit that referenced this pull request May 19, 2021
* sdf 1.8: Add <double_sided> to material from #410
* sdf 1.8: Add lightmap to 1.8 spec from #429
* sdf 1.8: document Add L16 camera pixel format from #487

Signed-off-by: Ian Chen <[email protected]>

* sdf 1.8: Decrease far clip lower bound from #435

Signed-off-by: Nate Koenig <[email protected]>

* sdf 1.8: Added render_order to material from #446

Signed-off-by: ahcorde <[email protected]>

* sdf 1.8: Add camera type aliases to docs. from #514
* sdf 1.8: Improve docs of collision_bitmask from #521

Signed-off-by: Martin Pecka <[email protected]>

* sdf 1.8: support nested models in @attached_to from #316

Signed-off-by: Steve Peters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome 🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants