Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added issue & PR templates #486

Merged
merged 5 commits into from
Mar 1, 2021
Merged

Added issue & PR templates #486

merged 5 commits into from
Mar 1, 2021

Conversation

jennuine
Copy link
Collaborator

@jennuine jennuine commented Feb 5, 2021

Related to gazebosim/docs#138

Adds a template for opening new issues and pull requests

@jennuine
added issue & PR templates
8f73998 
Signed-off-by: Jenn Nguyen <[email protected]>
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Feb 5, 2021
chapulina
chapulina approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the open PRs link updated, but I'd like @azeey 's confirmation that all the Ignition language is alright.

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
azeey
azeey reviewed Feb 5, 2021
View reviewed changes
Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but I'd like @azeey 's confirmation that all the Ignition language is alright.

I'm good with all the links. I left a comment about codecheck.

.github/ISSUE_TEMPLATE/feature_request.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@jennuine
updated templates
04f46cc 
Signed-off-by: Jenn Nguyen <[email protected]>
@jennuine jennuine marked this pull request as draft February 13, 2021 01:57
@jennuine jennuine marked this pull request as ready for review February 16, 2021 23:07
@jennuine jennuine requested a review from azeey February 16, 2021 23:07
@jennuine
removed port.md file
144196c 
Signed-off-by: Jenn Nguyen <[email protected]>
@jennuine jennuine merged commit 5928410 into master Mar 1, 2021
@jennuine jennuine deleted the jennuine/templates branch March 1, 2021 16:20
@chapulina chapulina mentioned this pull request Jun 28, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@azeey azeey azeey approved these changes

Assignees
No one assigned
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jennuine @azeey @chapulina