Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 12 -> main #886

Merged
merged 16 commits into from
Mar 18, 2022
Merged

Merge 12 -> main #886

merged 16 commits into from
Mar 18, 2022

Conversation

scpeters
Copy link
Member

➡️ Forward port

Port sdf12 to main

Branch comparison: main...sdf12

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

WilliamLewww and others added 15 commits March 2, 2022 14:25
Signed-off-by: William Lew <[email protected]>
Signed-off-by: William Lew <[email protected]>
* GitHub CI: only build pxr on 20.04
* Add comment mentioning issue #869

Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Co-authored-by: Ashton Larkin <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Co-authored-by: Ashton Larkin <[email protected]>
* enable static checkers

Signed-off-by: Louise Poubel <[email protected]>

* Fix focal linting errors

Signed-off-by: Steve Peters <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
* Fix a lack of ParserConfig propagation.

Copied from patch in RobotLocomotion/drake#16791
by jwnimmer-tri.

* Pass ParserConfig to parser helper functions

Require ParserConfig argument in parser.cc's private
helper functions: initDoc, initXml, and _initFile.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from azeey as a code owner March 18, 2022 17:59
@scpeters scpeters changed the title Merge12main Merge 12 -> main Mar 18, 2022
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 18, 2022
@scpeters scpeters changed the base branch from sdf12 to main March 18, 2022 18:01
@scpeters
Copy link
Member Author

why do I so often target the wrong branch with forward-porting PRs

@chapulina chapulina added 🌱 garden Ignition Garden and removed 🏯 fortress Ignition Fortress labels Mar 18, 2022
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with happy CI

@scpeters scpeters enabled auto-merge March 18, 2022 18:37
@scpeters
Copy link
Member Author

auto-merge enabled

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2022

Codecov Report

Merging #886 (feb4abd) into main (297aef2) will decrease coverage by 0.49%.
The diff coverage is 72.06%.

❗ Current head feb4abd differs from pull request most recent head 0a74524. Consider uploading reports for the commit 0a74524 to get more accurate results

@@            Coverage Diff             @@
##             main     #886      +/-   ##
==========================================
- Coverage   88.65%   88.16%   -0.50%     
==========================================
  Files          92      100       +8     
  Lines       14222    14630     +408     
==========================================
+ Hits        12608    12898     +290     
- Misses       1614     1732     +118     
Impacted Files Coverage Δ
usd/src/usd_parser/USD2SDF.cc 53.33% <53.33%> (ø)
usd/src/usd_parser/USDMaterial.cc 64.90% <64.90%> (ø)
usd/src/usd_parser/USDData.cc 66.94% <66.94%> (ø)
usd/src/usd_parser/Parser.cc 71.42% <71.42%> (ø)
usd/src/usd_parser/USDWorld.cc 73.07% <73.07%> (ø)
usd/src/usd_parser/USDPhysics.cc 85.00% <85.00%> (ø)
usd/src/cmd/usd2sdf.cc 85.18% <85.18%> (ø)
src/parser.cc 87.59% <95.00%> (+0.02%) ⬆️
usd/src/usd_parser/USDStage.cc 97.14% <97.14%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 297aef2...0a74524. Read the comment docs.

@scpeters scpeters merged commit e648189 into main Mar 18, 2022
@scpeters scpeters deleted the merge12main branch March 18, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants