Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging and warnings #1125

Merged
merged 10 commits into from
Feb 5, 2024
Merged

Improve logging and warnings #1125

merged 10 commits into from
Feb 5, 2024

Conversation

gboeing
Copy link
Owner

@gboeing gboeing commented Feb 1, 2024

This PR:

  • improves log messaging and makes level explicit
  • makes user warnings explicitly UserWarnings
  • ensure imports used only for type hinting are guarded in if TYPE_CHECKING: block and ignore these blocks in test coverage report (relevant)

See also #1106

@gboeing gboeing changed the base branch from main to v2 February 1, 2024 05:27
@gboeing gboeing mentioned this pull request Feb 1, 2024
13 tasks
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (69df552) 97.95% compared to head (dcc6c47) 97.93%.

❗ Current head dcc6c47 differs from pull request most recent head de5e84e. Consider uploading reports for the commit de5e84e to get more accurate results

Files Patch % Lines
osmnx/simplification.py 81.81% 2 Missing ⚠️
osmnx/stats.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #1125      +/-   ##
==========================================
- Coverage   97.95%   97.93%   -0.02%     
==========================================
  Files          25       25              
  Lines        2343     2423      +80     
==========================================
+ Hits         2295     2373      +78     
- Misses         48       50       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gboeing gboeing changed the title Improve log messages and error messages Improve logging and warnings Feb 5, 2024
@gboeing gboeing merged commit e1179d9 into v2 Feb 5, 2024
5 checks passed
@gboeing gboeing deleted the msg branch February 5, 2024 16:06
@gboeing
Copy link
Owner Author

gboeing commented May 3, 2024

The first pre-release OSMnx v2 beta has been released. Testers needed! See #1123 for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant